Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Admonitions for Migrated Lectures #340

Merged
merged 9 commits into from
Feb 4, 2024
Merged

Add Admonitions for Migrated Lectures #340

merged 9 commits into from
Feb 4, 2024

Conversation

HumphreyYang
Copy link
Collaborator

This PR migrates duplicate lectures in #282

@netlify Netlify
Copy link

netlify bot commented Jan 29, 2024 •
edited
Loading

✅ Deploy Preview for taupe-gaufre-c4e660 ready!

Name Link
🔨 Latest commit 212d6be
🔍 Latest deploy log https://app.netlify.com/sites/taupe-gaufre-c4e660/deploys/65c019ec546fc40008e1400d
😎 Deploy Preview https://deploy-preview-340--taupe-gaufre-c4e660.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 29, 2024 •
edited
Loading

🚀 Deployed on https://65c01be8f775d9b8a09d7e5f--taupe-gaufre-c4e660.netlify.app

mmcky
mmcky reviewed Jan 29, 2024
View reviewed changes
lectures/short_path.md Outdated
@@ -23,6 +23,16 @@ kernelspec:
```{index} single: Dynamic Programming; Shortest Paths
```

```{contents} Contents
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HumphreyYang we should remove these content blocks as they are not required. The theme builds a RHS toc in the margin.

@mmcky mmcky mentioned this pull request Jan 29, 2024
Merged
@HumphreyYang
Copy link
Collaborator Author

Hi @mmcky,

Many thanks for letting me know.

I have removed both content tags in geom_series and short_path. There is no other content tags in this series based on a global search.

@mmcky
Copy link
Contributor

mmcky commented Feb 1, 2024

@HumphreyYang looks like we just need to update a link

/home/runner/work/lecture-python-intro/lecture-python-intro/lectures/complex_and_trig.md:39: WARNING: unknown document: samuelson

@HumphreyYang
Copy link
Collaborator Author

Many thanks @mmcky,

This is linked to a lecture in the intermediate series.

Should I link it to our new migrated series or the intermediate series?

@HumphreyYang
Copy link
Collaborator Author

Hi @mmcky,

Please let me know your thoughts on this when you are available:

This is linked to a lecture in the intermediate series.

Should I link it to our new migrated series or the intermediate series?

@mmcky
Copy link
Contributor

mmcky commented Feb 4, 2024

thanks @HumphreyYang

Should I link it to our new migrated series or the intermediate series?

This should be linked to the new migrated (topic based series)

@HumphreyYang HumphreyYang mentioned this pull request Feb 4, 2024
Closed
@HumphreyYang
Copy link
Collaborator Author

Hi @mmcky,

I think this is ready for your review now.

@mmcky mmcky self-requested a review February 4, 2024 23:26
@mmcky mmcky merged commit dfd749d into main Feb 4, 2024
6 checks passed
@mmcky mmcky deleted the migrate-tags branch February 4, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmcky mmcky mmcky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HumphreyYang @mmcky